package melange

  1. Overview
  2. Docs
Legend:
Page
Library
Module
Module type
Parameter
Class
Class type
Source

Source file bs_ast_invariant.ml

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
(* Copyright (C) 2015-2016 Bloomberg Finance L.P.
 * Copyright (C) 2017- Hongbo Zhang, Authors of ReScript
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Lesser General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * In addition to the permissions granted to you by the LGPL, you may combine
 * or link a "work that uses the Library" with a publicly distributed version
 * of this file to produce a combined library or application, then distribute
 * that combined work under the terms of your choosing, with no requirement
 * to comply with the obligations normally placed on you by section 4 of the
 * LGPL version 3 (or the corresponding section of a later version of the LGPL
 * should you choose to use a later version).
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. *)

open Ppxlib

module Warnings = struct
  type t =
    | Unused_attribute of string
    | Fragile_external of string
    | Redundant_mel_string
    | Deprecated_uncurry_attribute
    | Deprecated_attribute_namespace
    | Deprecated_val

  let kind = function
    | Unused_attribute _ -> "unused"
    | Fragile_external _ -> "fragile"
    | Redundant_mel_string -> "redundant"
    | Deprecated_uncurry_attribute | Deprecated_attribute_namespace
    | Deprecated_val ->
        "deprecated"

  let pp fmt t =
    match t with
    | Unused_attribute s ->
        Format.fprintf fmt
          "Unused attribute [%@%s]@\n\
           This means such annotation is not annotated properly.@\n\
           For example, some annotations are only meaningful in externals\n"
          s
    | Fragile_external s ->
        Format.fprintf fmt
          "%s : the external name is inferred from val name is unsafe from \
           refactoring when changing value name"
          s
    | Redundant_mel_string ->
        Format.fprintf fmt
          "[@mel.string] is redundant here, you can safely remove it"
    | Deprecated_uncurry_attribute ->
        Format.fprintf fmt
          "The `[@bs]' uncurry attribute is deprecated and will be removed in \
           the next release.@\n\
           Use `[@u]' instead."
    | Deprecated_attribute_namespace ->
        Format.fprintf fmt
          "The `[@bs.*]' attributes are deprecated and will be removed in the\n\
           next release.@\n\
           Use `[@mel.*]' instead."
    | Deprecated_val ->
        Format.fprintf fmt
          "`[@mel.val]' attributes are redundant and will be removed in the \
           next release.@\n\
           Consider removing them from any external declarations."
end

let warn ~loc msg =
  let module Location = Ocaml_common.Location in
  Location.prerr_alert loc
    {
      Ocaml_common.Warnings.kind = Warnings.kind msg;
      message = Format.asprintf "%a" Warnings.pp msg;
      def = Location.none;
      use = loc;
    }

(** Warning unused bs attributes
    Note if we warn `deriving` too,
    it may fail third party ppxes
*)
let is_bs_attribute txt =
  let len = String.length txt in
  (len = 1 && String.unsafe_get txt 0 = 'u')
  || len >= 2
     (*TODO: check the stringing padding rule, this predicate may not be needed *)
     && String.unsafe_get txt 0 = 'b'
     && String.unsafe_get txt 1 = 's'
     && (len = 2 || String.unsafe_get txt 2 = '.')
  || String.unsafe_get txt 0 = 'm'
     && String.unsafe_get txt 1 = 'e'
     && String.unsafe_get txt 2 = 'l'
     && String.unsafe_get txt 3 = '.'

let used_attributes : string Asttypes.loc Hash_set_poly.t =
  Hash_set_poly.create 16

(* #if true *)
(* let dump_attribute fmt = (fun (sloc : string Asttypes.loc) -> *)
(* Format.fprintf fmt "@[%s @]" sloc.txt (* (Printast.payload 0 ) payload *) *)
(* ) *)

(* let dump_used_attributes fmt = *)
(* Format.fprintf fmt "Used attributes Listing Start:@."; *)
(* Hash_set_poly.iter  used_attributes (fun attr -> dump_attribute fmt attr) ; *)
(* Format.fprintf fmt "Used attributes Listing End:@." *)
(* #endif *)

(* only mark non-ghost used bs attribute *)
let mark_used_bs_attribute ({ attr_name = x; _ } : Parsetree.attribute) =
  if not x.loc.loc_ghost then Hash_set_poly.add used_attributes x

let warn_unused_attribute
    ({ attr_name = { txt; loc } as sloc; _ } : Parsetree.attribute) : unit =
  if
    is_bs_attribute txt && (not loc.loc_ghost)
    && not (Hash_set_poly.mem used_attributes sloc)
  then
    (* #if true *)
    (* (*COMMENT*) *)
    (* dump_used_attributes Format.err_formatter; *)
    (* dump_attribute Format.err_formatter sloc; *)
    (* #endif *)
    warn ~loc (Unused_attribute txt)

let warn_discarded_unused_attributes (attrs : Parsetree.attributes) =
  if attrs <> [] then List.iter warn_unused_attribute attrs

(* Note we only used Bs_ast_iterator here, we can reuse compiler-libs instead
   of rolling our own *)
let emit_external_warnings : Ast_traverse.iter =
  object (_self)
    inherit Ast_traverse.iter as super
    method! attribute attr = warn_unused_attribute attr

    method! label_declaration lbl =
      List.iter
        (fun attr ->
          match attr with
          | { attr_name = { txt = "mel.as" | "bs.as" | "as"; _ }; _ } ->
              mark_used_bs_attribute attr
          | _ -> ())
        lbl.pld_attributes;
      super#label_declaration lbl
  end

let emit_external_warnings_on_structure (stru : Parsetree.structure) =
  emit_external_warnings#structure stru

let emit_external_warnings_on_signature (sigi : Parsetree.signature) =
  emit_external_warnings#signature sigi
OCaml

Innovation. Community. Security.